arm64:dts:aspeed: Add DIMM devices for SP7#263
Conversation
|
I noticed that most of this is duplicated between the platforms. Should we have a dtsi for the common changes and just include the dtsi when applicable for the specific platform dtses? (not really applicable for this review, but just a thought) |
mahkurap
left a comment
mahkurap
left a comment
There was a problem hiding this comment.
There is a typo in the commit message. instead of sp8, it is spelled as sp&.
| #define JESD300_PMIC_I2C_MODE(bus, index, addr) \ | ||
| pmic_ ## bus ## _ ## index: pmic@addr{ \ | ||
| reg = <0x ## addr 0x0 0x40>; \ | ||
| compatible = "eeprom"; \ |
There was a problem hiding this comment.
This is a copy from Turin changes from Aspeed that has been working.
It also worked in SP7.
we can try it later on, but not for today's release
|
Add DIMM SPD and PMIC devices to SP7 platforms for i3c2 (P0) and i3c3 (P1). The i3c buses will run in i2c mode from BMC side. Tested: - verified in Congo and Morocco Signed-off-by: modolaty <mohsen.dolaty@amd.com>
good point. But since we are putting these changes in a public hub and it is our choice to use the system in i2c mode, it makes more sense to do it in dts rather than dtsi |
Nice idea. But because linux-aspeed is a public code and this is a our design to access SP7 in i2c mode, it makes more sense to do it in dts rather changing dtsi |
4 participants
Add DIMM SPD and PMIC devices to SP7 platforms for i3c2 (P0) and i3c3 (P1).
The i3c buses will run in i2c mode from BMC side.
Tested: